allow local issuance for did:web #2641
Conversation
There was a problem hiding this comment.
I don't like this monkey patch too much. The wallet owner now hasn't anything to decide whether it actually wants the credential. And it's a bit of magic with obscure limitations (no JWT).
Wouldn't it be better to provide a REST API to load credentials into the wallet? Then the existing issue API (no publish) can be used to create the VC, then the new API (something like POST internal/vcr/v1/holder/{did}/vc for putting it in any wallet.
| return createdVC, nil | ||
| } | ||
|
|
||
| func (i issuer) tryLocalIssuance(ctx context.Context, options CredentialOptions, createdVC *vc.VerifiableCredential) { | ||
| if options.Publish { | ||
| // not supported, return silently |
There was a problem hiding this comment.
but JWTs can't be loaded into the local wallet this way?
That would be a nice intermediate solution. It would require 2 API calls for vendors to create their credentials. It would help us to continue building the rest. |
closes #2640
this allows an issuer to issue to a wallet within the same node. This only happend when the VC is not public, not published, the receiver is a did:web and when it's owned by the node.